ready #2570
Open
ready #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Sep 22, 2024
src/App.tsx
Outdated
Comment on lines
10
to
15
| type Todo = { | ||
| userId: number; | ||
| id: number; | ||
| title: string; | ||
| completed: boolean; | ||
| }; |
src/components/TodoList/TodoList.tsx
Outdated
Comment on lines
31
to
41
| useEffect(() => { | ||
| getTodos() | ||
| .then(todosData => { | ||
| setTodos(todosData); | ||
| setLoading(false); | ||
| }) | ||
| .catch(error => { | ||
| // eslint-disable-next-line no-console | ||
| console.error('Ошибка при загрузке задач:', error); | ||
| }); | ||
| }, []); |
There was a problem hiding this comment.
you can move this logic to the App.tsx
src/components/TodoList/TodoList.tsx
Outdated
Comment on lines
43
to
53
| let filteredTodos = todos.filter(todo => | ||
| todo.title.toLowerCase().includes(filterBy.toLowerCase()), | ||
| ); | ||
|
|
||
| <tr data-cy="todo" className=""> | ||
| <td className="is-vcentered">8</td> | ||
| <td className="is-vcentered"> | ||
| <span className="icon" data-cy="iconCompleted"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| </td> | ||
| <td className="is-vcentered is-expanded"> | ||
| <p className="has-text-success">quo adipisci enim quam ut ab</p> | ||
| </td> | ||
| <td className="has-text-right is-vcentered"> | ||
| <button data-cy="selectButton" className="button" type="button"> | ||
| if (filterBySelect !== 'all') { | ||
| if (filterBySelect === 'completed') { | ||
| filteredTodos = filteredTodos.filter(todo => todo.completed === true); | ||
| } else { | ||
| filteredTodos = filteredTodos.filter(todo => todo.completed === false); | ||
| } | ||
| } |
Comment on lines
5
to
10
| type Todo = { | ||
| userId: number; | ||
| id: number; | ||
| title: string; | ||
| completed: boolean; | ||
| }; |
|
|
||
| const todo = todos.find(cTodo => cTodo.id === modalShowId); // Поиск задачи по ID | ||
|
|
||
| // Загружаем данные пользователя при наличии todo |
There was a problem hiding this comment.
Remove comment. Try to write obvious code that explains all we need without comments)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK