didnt know tests failed #2565
Open
didnt know tests failed #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Sep 17, 2024
src/components/TodoList/TodoList.tsx
Outdated
Comment on lines
32
to
60
| <tr data-cy="todo" className="" key={todo.id}> | ||
| <td className="is-vcentered">{todo.id}</td> | ||
| {todo.completed ? ( | ||
| <td className="is-vcentered"> | ||
| <span className="icon" data-cy="iconCompleted"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| </td> | ||
| ) : ( | ||
| <td className="is-vcentered" /> | ||
| )} | ||
| <td className="is-vcentered is-expanded"> | ||
| <p | ||
| className={ | ||
| todo.completed ? 'has-text-success' : 'has-text-danger' | ||
| } | ||
| > | ||
| {todo.title} | ||
| </p> | ||
| </td> | ||
| <td className="has-text-right is-vcentered"> | ||
| <button | ||
| data-cy="selectButton" | ||
| className="button" | ||
| type="button" | ||
| onClick={() => openModal(todo)} | ||
| > | ||
| <span className="icon"> | ||
| <i |
There was a problem hiding this comment.
Move this logic to the TodoItem component
There was a problem hiding this comment.
why? there are no tests for this component. As i understand i must using this "You are given the markup for the App, TodosList, TodoFilter, TodoModal and Loader components. Load data from the API and show it using the given components."
There was a problem hiding this comment.
After this fix, this component will be more readable, it will be a good practice
src/components/TodoList/TodoList.tsx
Outdated
| <td className="is-vcentered is-expanded"> | ||
| <p | ||
| className={ | ||
| todo.completed ? 'has-text-success' : 'has-text-danger' |
There was a problem hiding this comment.
Use the classnames library for add classes with condition, fix it everywhere
src/components/TodoList/TodoList.tsx
Outdated
| todo.completed ? 'has-text-success' : 'has-text-danger' | ||
| } | ||
| > | ||
| {todo.title} |
|
|
||
| export const App: React.FC = () => { | ||
| const [todos, setTodos] = useState<Todo[]>([]); | ||
| const [filteredTodos, setFilteredTodos] = useState<Todo[]>([]); |
There was a problem hiding this comment.
Redundant state
Suggested change
| const [filteredTodos, setFilteredTodos] = useState<Todo[]>([]); |
src/App.tsx
Outdated
Comment on lines
20
to
24
| getTodos().then(todos1 => { | ||
| setTodos(todos1); | ||
| setFilteredTodos(todos1); | ||
| setLoading(false); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| getTodos().then(todos1 => { | |
| setTodos(todos1); | |
| setFilteredTodos(todos1); | |
| setLoading(false); | |
| }); | |
| getTodos() | |
| .then(setTodos) | |
| .finally(() => setLoading(false)); |
src/App.tsx
Outdated
|
|
||
| export const App: React.FC = () => { | ||
| const [todos, setTodos] = useState<Todo[]>([]); | ||
| const [filteredTodos, setFilteredTodos] = useState<Todo[]>([]); | ||
| const [loading, setLoading] = useState<boolean>(true); |
There was a problem hiding this comment.
Suggested change
| const [loading, setLoading] = useState<boolean>(true); | |
| const [isLoading, setIsLoading] = useState<boolean>(true); |
volodymyr-soltys97
suggested changes
Sep 17, 2024
|
|
||
| export const App: React.FC = () => { | ||
| const [todos, setTodos] = useState<Todo[]>([]); | ||
| const [filteredTodos, setFilteredTodos] = useState<Todo[]>([]); |
src/App.tsx
Outdated
Comment on lines
18
to
25
| const fetchTodos = async () => { | ||
| const todosData = await getTodos(); | ||
|
|
||
| setTodos(todosData); | ||
| setFilteredTodos(todosData); | ||
| }; | ||
|
|
||
| fetchTodos(); |
There was a problem hiding this comment.
Suggested change
| const fetchTodos = async () => { | |
| const todosData = await getTodos(); | |
| setTodos(todosData); | |
| setFilteredTodos(todosData); | |
| }; | |
| fetchTodos(); | |
| setIsLoading(true) | |
| getTodos() | |
| .then(setTodos) | |
| .finally(() => setIsLoading(false)) |
src/App.tsx
Outdated
Comment on lines
15
to
16
| const [selectedTodo, setSelectedTodo] = useState<Todo | null>(null); | ||
|
|
There was a problem hiding this comment.
Create a state for isLoading
src/components/TodoList/TodoList.tsx
Outdated
Comment on lines
32
to
60
| <tr data-cy="todo" className="" key={todo.id}> | ||
| <td className="is-vcentered">{todo.id}</td> | ||
| {todo.completed ? ( | ||
| <td className="is-vcentered"> | ||
| <span className="icon" data-cy="iconCompleted"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| </td> | ||
| ) : ( | ||
| <td className="is-vcentered" /> | ||
| )} | ||
| <td className="is-vcentered is-expanded"> | ||
| <p | ||
| className={ | ||
| todo.completed ? 'has-text-success' : 'has-text-danger' | ||
| } | ||
| > | ||
| {todo.title} | ||
| </p> | ||
| </td> | ||
| <td className="has-text-right is-vcentered"> | ||
| <button | ||
| data-cy="selectButton" | ||
| className="button" | ||
| type="button" | ||
| onClick={() => openModal(todo)} | ||
| > | ||
| <span className="icon"> | ||
| <i |
There was a problem hiding this comment.
After this fix, this component will be more readable, it will be a good practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
Everything is works...but i cant pass the tests