Develop #2563
Open
Develop #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2024 11:36
etojeDenys
suggested changes
Sep 16, 2024
src/components/TodoList/TodoList.tsx
Outdated
Comment on lines
35
to
37
| {todos.map(todo => ( | ||
| <tbody key={todo.id}> | ||
| <tr |
There was a problem hiding this comment.
you should map the tr elements, not tbody
volodymyr-soltys97
suggested changes
Sep 16, 2024
Comment on lines
+23
to
+28
| .then(todosFromServer => { | ||
| setTodos(todosFromServer); | ||
| }) | ||
| .then(() => { | ||
| setLoader(false); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| .then(todosFromServer => { | |
| setTodos(todosFromServer); | |
| }) | |
| .then(() => { | |
| setLoader(false); | |
| }); | |
| .then(setTodos) | |
| .then(() => setLoader(false)); |
There was a problem hiding this comment.
red minuses - you need to delete it
green plusses - you need to add it
src/App.tsx
Outdated
Comment on lines
44
to
49
| if (completedSearch !== 'all') { | ||
| if (completedSearch === 'completed') { | ||
| visTodos = visTodos.filter(todo => todo.completed === true); | ||
| } | ||
|
|
||
| if (completedSearch === 'active') { |
There was a problem hiding this comment.
Create a enum for 'all', 'active', 'completed' and use it everywhere
src/App.tsx
Outdated
|
|
||
| if (completedSearch !== 'all') { | ||
| if (completedSearch === 'completed') { | ||
| visTodos = visTodos.filter(todo => todo.completed === true); |
There was a problem hiding this comment.
Suggested change
| visTodos = visTodos.filter(todo => todo.completed === true); | |
| visTodos = visTodos.filter(todo => todo.completed); |
src/App.tsx
Outdated
| } | ||
|
|
||
| if (completedSearch === 'active') { | ||
| visTodos = visTodos.filter(todo => todo.completed === false); |
There was a problem hiding this comment.
Suggested change
| visTodos = visTodos.filter(todo => todo.completed === false); | |
| visTodos = visTodos.filter(todo => !todo.completed); |
src/components/TodoList/TodoList.tsx
Outdated
Comment on lines
37
to
59
| <tr | ||
| key={todo.id} | ||
| data-cy="todo" | ||
| className={cn({ | ||
| 'has-background-info-light': todo.id === modalId, | ||
| })} | ||
| > | ||
| <td className="is-vcentered">{todo.id}</td> | ||
| <td className="is-vcentered"> | ||
| {todo.completed && ( | ||
| <span className="icon" data-cy="iconCompleted"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| )} | ||
| </td> | ||
| <td className="is-vcentered is-expanded"> | ||
| <p | ||
| className={cn({ | ||
| 'has-text-danger': !todo.completed, | ||
| 'has-text-success': todo.completed, | ||
| })} | ||
| > | ||
| {todo.title} |
There was a problem hiding this comment.
Move this logic to the TodoItem component
src/components/TodoList/TodoList.tsx
Outdated
| > | ||
| <td className="is-vcentered">{todo.id}</td> | ||
| <td className="is-vcentered"> | ||
| {todo.completed && ( |
volodymyr-soltys97
suggested changes
Sep 16, 2024
|
etojeDenys
approved these changes
Sep 17, 2024
Comment on lines
+23
to
+28
| .then(todosFromServer => { | ||
| setTodos(todosFromServer); | ||
| }) | ||
| .then(() => { | ||
| setLoader(false); | ||
| }); |
There was a problem hiding this comment.
red minuses - you need to delete it
green plusses - you need to add it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
два теста падають але в мене немає таких todo які є в тесті