Solution #1380
Open
Solution #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YukihiroSM
suggested changes
Sep 30, 2024
Comment on lines
+1
to
+2
| from app.people.customer import Customer | ||
| from app.people.cinema_staff import Cleaner |
There was a problem hiding this comment.
Why do you need these imports if you are not using them?
There was a problem hiding this comment.
Why do you need these imports if you are not using them?
Because i use them in fucntion annotaition. Have flake8 F821 undefined name
There was a problem hiding this comment.
Then it's better to remove double quotes
app/main.py
Outdated
| def cinema_visit(customers: list, hall_number: int, cleaner: str, movie: str): | ||
| # write you code here | ||
| pass | ||
| def cinema_visit(customers: list, hall_number: int, |
There was a problem hiding this comment.
It's better to specify list of what do you expect here. For example: list[int], or list[dict]
YukihiroSM
suggested changes
Sep 30, 2024
app/cinema/bar.py
Outdated
|
|
||
| class CinemaBar: | ||
| @staticmethod | ||
| def sell_product(product: str, customer: "Customer") -> None: |
There was a problem hiding this comment.
Same as in hall.py here. Fix it, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.