-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1266
base: master
Are you sure you want to change the base?
Solution #1266
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
from app.people.customer import Customer | ||
|
||
|
||
class CinemaBar: | ||
@staticmethod | ||
def sell_product(customer: Customer, product: str) -> None: | ||
print(f"Cinema bar sold {product} to {customer.name}.") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
from __future__ import annotations | ||
import app.people.customer as customer | ||
import app.people.cinema_staff as cinema_staff | ||
|
||
|
||
class CinemaHall: | ||
def __init__(self, number: int) -> None: | ||
self.number = number | ||
|
||
def movie_session(self, | ||
movie_name: str, | ||
customers: list, | ||
cleaning_staff: cinema_staff.Cleaner) -> None: | ||
|
||
print(f'"{movie_name}" started in hall number {self.number}.') | ||
for someone in customers: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bad variable name. Use the singular when iterating. For example: |
||
one = customer.Customer(someone.name, "") | ||
one.watch_movie(movie_name) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why create another one from an already created customer? This is already an instance of the Customer class, so you should use hist methods right away. |
||
|
||
print(f'"{movie_name}" ended.') | ||
cleaning_staff.clean_hall(self.number) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,16 @@ | ||
# write your imports here | ||
from app.cinema.hall import CinemaHall | ||
from app.cinema.bar import CinemaBar | ||
from app.people.customer import Customer | ||
from app.people.cinema_staff import Cleaner | ||
|
||
|
||
def cinema_visit(customers: list, hall_number: int, cleaner: str, movie: str): | ||
# write you code here | ||
pass | ||
def cinema_visit(customers: list, | ||
hall_number: int, | ||
cleaner: str, | ||
movie: str) -> None: | ||
all_customers = [Customer(someone["name"], someone["food"]) | ||
for someone in customers] | ||
for someone in all_customers: | ||
CinemaBar().sell_product(someone, someone.food) | ||
cinema_hall = CinemaHall(hall_number) | ||
cinema_hall.movie_session(movie, all_customers, Cleaner(cleaner)) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
class Cleaner: | ||
def __init__(self, name: str) -> None: | ||
self.name = name | ||
|
||
def clean_hall(self, hall_number: int) -> None: | ||
print(f"Cleaner {self.name} is cleaning hall number {hall_number}.") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class Customer: | ||
def __init__(self, name: str, food: str) -> None: | ||
self.name = name | ||
self.food = food | ||
|
||
def watch_movie(self, movie: str) -> None: | ||
print(f'{self.name} is watching "{movie}".') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to import a whole class and use it without
as
.