Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4908

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #4908

wants to merge 2 commits into from

Conversation

futdevelop
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on your Pull Request! 🌟 The issues mentioned are minor and don't critically impact the functionality or security of your code. For future reference, try to avoid using the * selector for performance reasons and remember to add empty lines between multiline sibling blocks of HTML for better readability. Also, keep an eye on consistent indentation for nested elements. Keep coding and refining your skills! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.

Comment on lines +1 to +4
* {
margin: 0;
padding: 0;
box-sizing: border-box;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use the * selector as it impacts performance. It's better to set styles only for elements that require them. If you need to set a global box-sizing, consider using html { box-sizing: border-box; } and then inherit from it using *, *::before, *::after { box-sizing: inherit; }.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants