-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #4908
base: master
Are you sure you want to change the base?
Develop #4908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on your Pull Request! 🌟 The issues mentioned are minor and don't critically impact the functionality or security of your code. For future reference, try to avoid using the *
selector for performance reasons and remember to add empty lines between multiline sibling blocks of HTML for better readability. Also, keep an eye on consistent indentation for nested elements. Keep coding and refining your skills! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between multiline sibling blocks of HTML for better readability, as per the checklist item 'Add empty lines between multiline sibling blocks of HTML'.
* { | ||
margin: 0; | ||
padding: 0; | ||
box-sizing: border-box; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use the *
selector as it impacts performance. It's better to set styles only for elements that require them. If you need to set a global box-sizing, consider using html { box-sizing: border-box; }
and then inherit from it using *, *::before, *::after { box-sizing: inherit; }
.
No description provided.