Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4903

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChristinaBagrilo
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! You've done a great job on this Pull Request. 👍 However, I noticed a few small issues with file paths and formatting that need your attention. Ensuring the star-active.svg image path is correct is crucial for the images to display properly. Also, adjusting the indentation and spacing between elements will greatly improve the readability of your code. These tweaks will make your project even better! Could you please make these changes? Keep up the good work! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -9,10 +9,56 @@
<title>Stars</title>
<link
rel="stylesheet"
href="./style.css"
href="style.css"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attributes in the tag should start on a new line with a 2-space indentation relative to the tag for consistency and readability.

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between sibling blocks of HTML to simplify reading, but do not add them between parent and child elements.

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each

block is a multiline sibling block. According to the guidelines, you should add empty lines between them to improve readability.

src/style.css Outdated
.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url(images/star-active.svg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a relative path that includes the src directory for consistency with the other background-image url on line 13. This ensures that the path is correct relative to the CSS file location.

margin-right: 0;
}

.stars--1 .stars__star:nth-child(-n + 1),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the nth-child pseudo-class is correct for targeting specific stars based on the parent class. However, ensure that the star-active.svg image path is correct and consistent with the project's directory structure.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your CSS for the star ratings is looking great! Just a small hiccup with the file paths, but that's an easy fix. Keep up the good work, and don't forget to double-check those paths to ensure everything shows up perfectly on the page. 🌟🛠 Remember, attention to detail can make a big difference in web development. Keep it up!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +17 to +23
<div class="stars stars--0">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty lines between multiline sibling blocks of HTML to improve readability. There should be an empty line between the different '.stars' divs.

Comment on lines +25 to +31
<div class="stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty lines between multiline sibling blocks of HTML to improve readability. There should be an empty line between the different '.stars' divs.

Comment on lines +33 to +39
<div class="stars stars--2">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty lines between multiline sibling blocks of HTML to improve readability. There should be an empty line between the different '.stars' divs.

Comment on lines +41 to +47
<div class="stars stars--3">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty lines between multiline sibling blocks of HTML to improve readability. There should be an empty line between the different '.stars' divs.

Comment on lines +49 to +55
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty lines between multiline sibling blocks of HTML to improve readability. There should be an empty line between the different '.stars' divs.

height: 16px;
width: 16px;
margin-right: 4px;
background-image: url(../src/images/star.svg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file path used in the background-image property seems to be incorrect. Since the CSS file is already in the src directory, the path should be relative to the current directory, not including src again. It should be url(images/star.svg).

.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url(../src/images/star-active.svg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, the file path for the active star should be url(images/star-active.svg).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants