Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4874

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

lizbarkovska
Copy link

  • DEMO LINK
  • TEST REPORT LINK
  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • Each BEM block has its own separate file
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on using CSS imports correctly! 👍 I'm approving your Pull Request as there are no critical issues with your code. Remember to keep an eye on consistent margins, use classes for styling, format your attributes neatly, leave empty lines for readability, and maintain consistent indentation. These tips will help you write even cleaner and more maintainable code! Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +15 to +62
<body class="page">
<div class="stars stars--0">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--2">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--3">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--5">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be empty lines between multiline sibling blocks of HTML to improve readability. Please add empty lines between the

blocks that have the class 'stars'.

Comment on lines 10 to 13
<link
rel="stylesheet"
href="./style.css"
href="styles/style.css"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attributes of the tag should be formatted correctly with each attribute starting on a new line and with 2-space indentation related to the tag. The tag’s closing bracket should be on the same level as the opening one.

Comment on lines +1 to +3
.page {
margin: 0;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, avoid using tag names for styling (except html and body). It's recommended to style elements using .classes. If .page is a class applied to the body or html tag, this is fine. Otherwise, consider using a class for styling specific elements.

Comment on lines 11 to 12
margin-right: 4px;
margin-bottom: 4px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be consistent with your margins (Add only top or bottom, but not both). In this case, you are adding both right and bottom margins to the .stars__star class. It's better to stick with one direction to avoid potential margin collapse issues.

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Almost done!

margin-bottom: 4px;
}

.stars--1 :first-child {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.stars--1 :first-child {
.stars--1 :first-child,
stars--2 :nth-child(-n + 2),
... {

Consider using commas to group selectors

width: 16px;
height: 16px;
margin-right: 4px;
margin-bottom: 4px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin-bottom: 4px;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants