-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4874
base: master
Are you sure you want to change the base?
add task solution #4874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on using CSS imports correctly! 👍 I'm approving your Pull Request as there are no critical issues with your code. Remember to keep an eye on consistent margins, use classes for styling, format your attributes neatly, leave empty lines for readability, and maintain consistent indentation. These tips will help you write even cleaner and more maintainable code! Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<body class="page"> | ||
<div class="stars stars--0"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
||
<div class="stars stars--1"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
||
<div class="stars stars--2"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
||
<div class="stars stars--3"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
||
<div class="stars stars--4"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
||
<div class="stars stars--5"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be empty lines between multiline sibling blocks of HTML to improve readability. Please add empty lines between the
<link | ||
rel="stylesheet" | ||
href="./style.css" | ||
href="styles/style.css" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attributes of the tag should be formatted correctly with each attribute starting on a new line and with 2-space indentation related to the tag. The tag’s closing bracket should be on the same level as the opening one.
.page { | ||
margin: 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the checklist, avoid using tag names for styling (except html
and body
). It's recommended to style elements using .classes
. If .page
is a class applied to the body
or html
tag, this is fine. Otherwise, consider using a class for styling specific elements.
src/styles/blocks/stars.css
Outdated
margin-right: 4px; | ||
margin-bottom: 4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be consistent with your margins (Add only top or bottom, but not both). In this case, you are adding both right and bottom margins to the .stars__star
class. It's better to stick with one direction to avoid potential margin collapse issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Almost done!
src/styles/blocks/stars.css
Outdated
margin-bottom: 4px; | ||
} | ||
|
||
.stars--1 :first-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.stars--1 :first-child { | |
.stars--1 :first-child, | |
stars--2 :nth-child(-n + 2), | |
... { |
Consider using commas to group selectors
src/styles/blocks/stars.css
Outdated
width: 16px; | ||
height: 16px; | ||
margin-right: 4px; | ||
margin-bottom: 4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
margin-bottom: 4px; |
Typical Mistakes
fromBEM
lesson theory are checked.