for bonus task, with new branch #1104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Sep 24, 2024
| @@ -11,6 +13,13 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService userService = new UserService(); | |||
There was a problem hiding this comment.
don't create UserService userService each time when method login is called
make it class-level variable
There was a problem hiding this comment.
How I can call method from UserService, when i don`t have member of this class?
There was a problem hiding this comment.
Can I make this method static?
Comment on lines
18
to
19
| for (User user:users | ||
| ) { |
There was a problem hiding this comment.
Suggested change
| for (User user:users | |
| ) { | |
| for (User user : users) { |
|
I tried fix mistakes |
Elena-Bruyako
suggested changes
Sep 29, 2024
| @@ -15,6 +15,11 @@ public class UserService { | |||
| * Return <code>null</code> if there is no suitable user | |||
| */ | |||
| public User findByEmail(String email) { | |||
| for (User user:users) { | |||
There was a problem hiding this comment.
Suggested change
| for (User user:users) { | |
| for (User user : users) { |
MentorMateAcademy
suggested changes
Sep 30, 2024
Comment on lines
18
to
24
| User user = userService.findByEmail(email); | ||
| if (user != null) { | ||
| if (user.getPassword().equals(password)) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Let`s simplify using one return in one line
MentorMateAcademy
suggested changes
Oct 1, 2024
| public boolean login(String email, String password) { | ||
| return false; | ||
| boolean userExist = false; |
There was a problem hiding this comment.
Suggested change
| boolean userExist = false; |
Comment on lines
20
to
26
| if (user != null) { | ||
| if (user.getPassword().equals(password)) { | ||
| userExist = true; | ||
| } | ||
| } | ||
| return userExist; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (user != null) { | |
| if (user.getPassword().equals(password)) { | |
| userExist = true; | |
| } | |
| } | |
| return userExist; | |
| } | |
| return user != null and user.password equals(password); | |
| } |
Elena-Bruyako
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.