Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for Doxygen Warnings #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test for Doxygen Warnings #8

wants to merge 2 commits into from

Conversation

jackdunger
Copy link

  • Clone the PR repo
  • build doxygen, and check the log for warnings
  • a single warning fails the test
    --> this should not be merged until the planned doxygen clean-up, as there are currently >5000 warnings..
  • dependent on the char_test PR for changes to task.py

mastbaum
mastbaum reviewed Apr 1, 2015
View reviewed changes
cog/tasks/doxytest.py Outdated
'code': str(code)}

# Get doxy log
rat_dir = os.join(work_dir,sha) if work_dir else sha
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be os.path.join.

@mastbaum
Copy link
Owner

mastbaum commented Apr 1, 2015

Works for me modulo the os.join, though it fails with an impressive 5579 warnings on our repo. So maybe we should wait until @straitm updates to only try doxygen on certain subdirectories?

@jackdunger
Copy link
Author

Thanks for looking at this. I've just fixed the os.join.
Agreed, best to wait until the doxyfile's changed and the existing warnings are gone,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackdunger @mastbaum