Refactored World management #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was it is more inline with how the other assets are managed. It also avoids silly issues, like a WorldDocument pointer not getting looked up successfully due to a file name mismatch. Fixes mapeditor#4042
* When loading a world, just set the file name it was loaded from. The canonical path will be determined by the WorldDocument. * When looking for a world for the current map, the MapScene no longer uses the canonical file path. This way, it will find the world as long as it was loaded from the same location. In general, I'm starting to doubt whether we should ever use the canonical file path for anything. It might be better, if the same resources loaded through different paths are simply regarded as different resources?
bjorn
force-pushed
the
refactor-world-management
branch
from
04cfd58
to
4e1f3ac
Compare
bjorn
commented
Aug 29, 2024
For consistency with the map and tileset reload, and because it is nice to allow the user to undo the reload, in case it threw away changes they did not want to lose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way it is more inline with how the other assets are managed. It also avoids silly issues, like a
WorldDocumentpointer not getting looked up successfully due to a file name mismatch.Fixes #4042