Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feedback when the Terrain Brush can't find some tiles #3778

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

bjorn
Copy link
Member

@bjorn bjorn commented Jul 6, 2023

  • These locations are now marked in red

  • The text "Missing terrain transition" appears on the status bar

* These locations are now marked in red

* The text "Missing terrain transition" appears on the status bar
@bjorn
Copy link
Member Author

bjorn commented Jul 6, 2023

Example of what this currently looks like:

image

This change only affects the Terrain Brush, but might also be useful in the Terrain Fill Mode. However, it relies on a custom WangBrushItem, which is currently only used by the WangBrush.

Allows highlighting the places where Wang Fill didn't find a tile also
for the Bucket Fill and Shape Fill tools.
@bjorn
Copy link
Member Author

bjorn commented Aug 1, 2023

I've also added the red regions to the Wang Fill Mode for the fill tools now. For completeness it would be good to still add:

  • Highlighting of these tiles for the Stamp Brush in Wang Fill Mode.
  • Showing "Missing terrain transition" text also for the Wang Fill Mode (currently only done by the Terrain Brush).

But I think none of that would really block this from going into the next patch release.

@bjorn bjorn merged commit 396eeff into mapeditor:master Aug 4, 2023
14 checks passed
@bjorn bjorn deleted the terrain-error-feedback branch August 4, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant