Skip to content

Commit

Permalink
Halborn audit fixes (#198)
Browse files Browse the repository at this point in the history
* Fix for HAL-01 - amount of cspr attached to pick_bid is now verified.

* Fix for HAL-02 issue.
Now only Created and Reclaimed bids can be picked.

* Fix for HAL-04 issue.
Now jobs after grace period cannot be submitted using submit_job
endpoint.

* Fix for HAL-03 issue.
Now burning more reputation that there is balance will cause a revert.

* Fix for HAL-05 issue.
Now the formal voting time in `is_in_time` function is calculated
correctly.

* Fix for HAL-06 issue.
Removed match statement from simple voter.

* Fix for HAL-08.
Removed unnecessary condition from `validate_cancel` function.

* Fix for HAL-03 issue - follow up.
To coply with existing tests, burning above balance will not cause revert, but the amount is checked.

* Fix for HAL-07 ownership transfer.
Now ownership transfer can be done in two steps.

* Fixes after CR.
Added ownership methods to daoids contract.
Rewrote ownership tests to use two-step transfer.

* Removed change_ownership from all contracts.
Rewrote tests to use two step ownership change only.
  • Loading branch information
kubaplas authored May 9, 2024
1 parent a31be43 commit 20c04d2
Show file tree
Hide file tree
Showing 58 changed files with 2,250 additions and 1,706 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-casper-rust-contract.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:

jobs:
build:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
Expand Down
Loading

0 comments on commit 20c04d2

Please sign in to comment.