-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #24 from mailerlite/bugfix/no-ref/filtering
Bugfix/no ref/filtering
- Loading branch information
Showing
22 changed files
with
245 additions
and
286 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,4 +91,5 @@ ENV/ | |
|
||
# Rope project settings | ||
.ropeproject | ||
.vscode | ||
.vscode | ||
toolset.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
authors = ["MailerLite <[email protected]>"] | ||
description = "The official MailerLite Python SDK" | ||
name = "mailerlite" | ||
version = "0.1.5" | ||
version = "0.1.6" | ||
|
||
[tool.poetry.dependencies] | ||
python = "^3.7" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,7 +79,6 @@ def test_given_proper_parameters_when_user_calls_create_then_new_campaign_is_cre | |
"subject": "This is a test campaign", | ||
"from_name": "Test Man", | ||
"from": "[email protected]", | ||
"content": "Hi there, this is a test campaign!", | ||
} | ||
], | ||
} | ||
|
@@ -108,13 +107,12 @@ def test_given_correct_parameters_when_user_calls_update_then_existing_campaign_ | |
): | ||
params = { | ||
"name": "New Campaign Name", | ||
"language_id": 2, | ||
"language_id": 1, | ||
"emails": [ | ||
{ | ||
"subject": "This is a new test campaign", | ||
"subject": "This is a new test campaign subject", | ||
"from_name": "Test Man", | ||
"from": "[email protected]", | ||
"content": "Hi there, this is a new test campaign!", | ||
} | ||
], | ||
} | ||
|
@@ -150,7 +148,7 @@ def test_given_correct_campaign_id_when_calling_get_then_campaign_is_returned( | |
) | ||
def test_list_of_all_campaigns_should_be_returned(self, campaign_keys): | ||
response = self.client.campaigns.list( | ||
limit=10, page=1, filter={"filter[status]": "draft"} | ||
limit=10, page=1, filter={"status": "draft"} | ||
) | ||
|
||
assert isinstance(response, dict) | ||
|
@@ -172,7 +170,7 @@ def test_given_correct_campaign_id_and_schedule_parameters_when_calling_schedule | |
): | ||
params = { | ||
"delivery": "scheduled", | ||
"schedule": {"date": "2022-12-31", "hours": "22", "minutes": "00"}, | ||
"schedule": {"date": "2024-03-31", "hours": "22", "minutes": "00"}, | ||
} | ||
response = self.client.campaigns.schedule(int(pytest.entity_id), params) | ||
|
||
|
@@ -214,11 +212,11 @@ def test_given_correct_campaign_id_when_calling_delete_then_campaign_is_removed( | |
): | ||
response = self.client.campaigns.delete(int(pytest.entity_id)) | ||
|
||
assert response == True | ||
assert response is True | ||
|
||
response = self.client.campaigns.delete(121212) | ||
|
||
assert response == False | ||
assert response is False | ||
|
||
def test_given_incorrect_campaign_id_when_calling_activity_then_type_error_is_returned( | ||
self, | ||
|
@@ -232,7 +230,7 @@ def test_given_incorrect_campaign_id_when_calling_activity_then_type_error_is_re | |
def test_given_correct_campaign_id_when_calling_activity_then_campaign_activity_information_is_returned( | ||
self, campaign_activity_keys | ||
): | ||
response = self.client.campaigns.activity(75037917434611569) | ||
response = self.client.campaigns.activity(106527960165516964) | ||
|
||
assert isinstance(response, dict) | ||
assert isinstance(response["data"], list) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.