Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply linting throughout project #137

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

gjmooney
Copy link
Contributor

Applies Ruff and Prettier linting throughout project.

@gjmooney gjmooney marked this pull request as ready for review January 30, 2024 09:27
Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

ipywebrtc/webrtc.py Outdated Show resolved Hide resolved
@maartenbreddels
Copy link
Owner

Nice!
Which tools did you use?
Because I want to have pre-commit and CI run these so that it stays tidy (similar to https://github.com/widgetti/ipyreact/pull/51/files)

@gjmooney
Copy link
Contributor Author

Nice! Which tools did you use? Because I want to have pre-commit and CI run these so that it stays tidy (similar to https://github.com/widgetti/ipyreact/pull/51/files)

I used the VSCode versions of Ruff and Prettier.

@maartenbreddels
Copy link
Owner

Would you like to add a similar setup of what @mariobuikhuizen did in widgetti/ipyreact#51 to this PR or would you rather have me do this?

@gjmooney
Copy link
Contributor Author

Would you like to add a similar setup of what @mariobuikhuizen did in widgetti/ipyreact#51 to this PR or would you rather have me do this?

Yea I can do that

Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou
Copy link
Collaborator

@maartenbreddels Is it ok to merge?

@maartenbreddels
Copy link
Owner

Excellent work 👍 thank you both

@maartenbreddels maartenbreddels merged commit 5685957 into maartenbreddels:master Feb 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants