Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record InChannel information for bundles; add test for ProvidesGVK filter. #1

Merged

Conversation

dtfranz
Copy link

@dtfranz dtfranz commented Sep 6, 2023

No description provided.

@m1kola m1kola force-pushed the remove_entity_sources_dfranz branch from 834d242 to f95c32c Compare September 7, 2023 10:38
@@ -54,7 +52,7 @@ func InChannel(channelName string) Predicate[Bundle] {
}
}

func ProvidesGVK(gvk *olmentity.GVK) Predicate[Bundle] {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (remove_entity_sources@b69c3ca). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                   Coverage Diff                    @@
##             remove_entity_sources       #1   +/-   ##
========================================================
  Coverage                         ?   80.94%           
========================================================
  Files                            ?       25           
  Lines                            ?     1055           
  Branches                         ?        0           
========================================================
  Hits                             ?      854           
  Misses                           ?      140           
  Partials                         ?       61           
Flag Coverage Δ
e2e 54.88% <0.00%> (?)
unit 77.29% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@m1kola m1kola merged commit 41ab31c into m1kola:remove_entity_sources Sep 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants