Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #82 Elision: match 1 or more returned types #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lverma14
Copy link
Owner

@lverma14 lverma14 commented Aug 21, 2023

This is a cleaner way to fix Issue uber-go#82 However, I am unable to account for what reason did
Match in pos.go originally return false in this case. By making this change, there's a risk that
I'm missing out an edge case where
if !got.IsValid() && m.Pos.IsValid() {
should return false but because of the above change would return true & give wrong result.
This passes on all the current testcases and some other tests that I tried but still a risk.

Can test by running

go run ./... -p testdata/patch/return_elision.patch testdata/test_files/test_return_elision.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant