Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind MailgunSender to ISender in singleton scope. #381

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brnn8r
Copy link

@brnn8r brnn8r commented Feb 23, 2024

Bind MailgunSender to ISender in singleton scope.

MailgunSender creates a new HttpClient for each instance of a MailgunSender object.

Based on Microsoft recommendations https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines#recommended-use I propose the MailgunSender should be bound in Singleton scope so that only one HttpClient is instantiated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant