Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: avoid useless create new empty object #1692

Closed
wants to merge 10 commits into from
Closed

perf: avoid useless create new empty object #1692

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d4569f1
perf: avoid useless create new empty object
cesco69 Oct 2, 2024
0908d8a
fix: lint
cesco69 Oct 3, 2024
1052895
perf: avoid useless create new empty object
cesco69 Oct 3, 2024
6c01443
perf: avoid useless create new empty object
cesco69 Oct 3, 2024
930ded4
chore: combine headers into spread of params
cesco69 Oct 3, 2024
a5b79c9
chore: combine headers into spread of params
cesco69 Oct 3, 2024
6202f0f
chore: combine headers into spread of params
cesco69 Oct 3, 2024
3fec1d1
chore: revert
cesco69 Oct 4, 2024
1bf33c6
chore: revert
cesco69 Oct 4, 2024
52934f7
chore: revert
cesco69 Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/runtime/src/routeGeneration/templates/express/expressTemplateService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,16 @@ export class ExpressTemplateService extends TemplateService<ExpressApiHandlerPar

protected returnHandler(params: ExpressReturnHandlerParameters) {
const { response, statusCode, data } = params;
let { headers } = params;
headers = headers || {};
const { headers } = params;
jackey8616 marked this conversation as resolved.
Show resolved Hide resolved

if (response.headersSent) {
return;
}
Object.keys(headers).forEach((name: string) => {
response.set(name, headers[name]);
});
if( headers ){
Object.keys(headers).forEach((name: string) => {
response.set(name, headers[name]);
});
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if statement is also can combine with or operator like:
Object.keys(headers || {}).forEach ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want avoid unecessary creation of new empty object

if (data && typeof data.pipe === 'function' && data.readable && typeof data._read === 'function') {
response.status(statusCode || 200);
data.pipe(response);
Expand Down
11 changes: 6 additions & 5 deletions packages/runtime/src/routeGeneration/templates/hapi/hapiTemplateService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,7 @@ export class HapiTemplateService extends TemplateService<HapiApiHandlerParameter

protected returnHandler(params: HapiReturnHandlerParameters) {
const { h, statusCode, data } = params;
let { headers } = params;
headers = headers || {};
const { headers } = params;

const tsoaResponsed = Object.getOwnPropertyDescriptor(h, hapiTsoaResponsed);
if (tsoaResponsed) {
Expand All @@ -129,9 +128,11 @@ export class HapiTemplateService extends TemplateService<HapiApiHandlerParameter

const response = data !== null && data !== undefined ? h.response(data).code(200) : h.response('').code(204);

Object.keys(headers).forEach((name: string) => {
response.header(name, headers[name]);
});
if( headers ){
Object.keys(headers).forEach((name: string) => {
response.header(name, headers[name]);
});
}

if (statusCode) {
response.code(statusCode);
Expand Down
7 changes: 4 additions & 3 deletions packages/runtime/src/routeGeneration/templates/koa/koaTemplateService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,7 @@ export class KoaTemplateService extends TemplateService<KoaApiHandlerParameters,

protected returnHandler(params: KoaReturnHandlerParameters): Promise<any> | Context | undefined {
const { context, next, statusCode, data } = params;
let { headers } = params;
headers = headers || {};
const { headers } = params;

const isResponsed = Object.getOwnPropertyDescriptor(context.response, koaTsoaResponsed);
if (!context.headerSent && !isResponsed) {
Expand All @@ -128,7 +127,9 @@ export class KoaTemplateService extends TemplateService<KoaApiHandlerParameters,
context.status = statusCode;
}

context.set(headers);
if( headers ){
context.set(headers);
}
Object.defineProperty(context.response, koaTsoaResponsed, {
value: true,
writable: false,
Expand Down
Loading