Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIS parser: Support few more username variations #4904

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

pyllyukko
Copy link
Contributor

E.g.:

  • realm/username
  • username@realm

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.98%. Comparing base (8ee35bb) to head (43a876e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4904   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files         431      431           
  Lines       38505    38505           
=======================================
  Hits        32725    32725           
  Misses       5780     5780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joachimmetz
Copy link
Member

@pyllyukko thanks for the changes could you add corresponding test cases for these as well?

@pyllyukko
Copy link
Contributor Author

@pyllyukko thanks for the changes could you add corresponding test cases for these as well?

Will do.

E.g.:

* realm/username
* username@realm
Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes

@joachimmetz joachimmetz merged commit ef17f65 into log2timeline:main Oct 6, 2024
9 of 10 checks passed
@joachimmetz joachimmetz self-assigned this Oct 6, 2024
@pyllyukko pyllyukko deleted the iis-usernames branch October 6, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants