Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Snowflake Terraform provider version #48

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

hovaesco
Copy link
Contributor

@hovaesco hovaesco commented Sep 19, 2024

Locking version due to:

  • The ~> operator is a pessimistic version constraint, which allows for automatic installation of newer minor releases. In this case, it can lead to unintended version changes, potentially causing inconsistent behavior across different versions. You can find more information here

Copy link

github-actions bot commented Sep 19, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-48.surge.sh 🎊

@@ -24,7 +24,7 @@ terraform {
required_providers {
snowflake = {
source = "Snowflake-Labs/snowflake"
version = "~> 0.61"
version = "= 0.92"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having looked at Terraform Snowflake Provider it is recommended to always use the newest version as they provide limited support. As the provider is in the experimental phase, I don't think locking the version could be a good idea, at least until a stable version with backward compatibility comes out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your perspective, but I have a different view on this. Having a working example is important for users who want to experiment and get hands-on experience with the platform. If the current example doesn’t work which is the case now, it could discourage users from trying out the platform.

While both LocalStack Snowflake and the Snowflake Terraform provider are still in development, it is even more important to lock versions. Without version constraints, there’s a higher risk of introducing breaking changes from either side, which could cause further issues and confusion. Locking the version, for now, ensures a stable reference point for users until both tools mature and offer better backward compatibility.

Copy link

@eruditmorina eruditmorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm:

Terraform Snowflake Provider versions later than 0.92 are dropping the ability to clone resources:

As such, this can be a quick fix to get un-blocked until resource cloning gets enabled after TSP v1. By that time we can consider the most stable version.

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a temporary workaround, but would be great to add a proper fix (that fixes the root cause of the error) over time as well.. 👍 Kudos for tackling this and unblocking users for now! 🎉

Maybe we should keep the backlog item open in the meantime, or at least add an xfailed test to the main repo, to make sure we're not dropping this? (btw, as a side note / nitpick - this repo is currently public, so perhaps better to not link issues from the internal backlog here)

@hovaesco hovaesco merged commit b6eebee into main Sep 23, 2024
2 checks passed
@hovaesco hovaesco deleted the hovaesco/terraform branch September 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants