-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock Snowflake Terraform provider version #48
Conversation
🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-48.surge.sh 🎊 |
@@ -24,7 +24,7 @@ terraform { | |||
required_providers { | |||
snowflake = { | |||
source = "Snowflake-Labs/snowflake" | |||
version = "~> 0.61" | |||
version = "= 0.92" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having looked at Terraform Snowflake Provider it is recommended to always use the newest version as they provide limited support. As the provider is in the experimental phase, I don't think locking the version could be a good idea, at least until a stable version with backward compatibility comes out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand your perspective, but I have a different view on this. Having a working example is important for users who want to experiment and get hands-on experience with the platform. If the current example doesn’t work which is the case now, it could discourage users from trying out the platform.
While both LocalStack Snowflake and the Snowflake Terraform provider are still in development, it is even more important to lock versions. Without version constraints, there’s a higher risk of introducing breaking changes from either side, which could cause further issues and confusion. Locking the version, for now, ensures a stable reference point for users until both tools mature and offer better backward compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm:
Terraform Snowflake Provider versions later than 0.92
are dropping the ability to clone resources:
- https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/CHANGES_BEFORE_V1.md#object-cloning
- https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/2842/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6aR73
As such, this can be a quick fix to get un-blocked until resource cloning gets enabled after TSP v1. By that time we can consider the most stable version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as a temporary workaround, but would be great to add a proper fix (that fixes the root cause of the error) over time as well.. 👍 Kudos for tackling this and unblocking users for now! 🎉
Maybe we should keep the backlog item open in the meantime, or at least add an xfail
ed test to the main repo, to make sure we're not dropping this? (btw, as a side note / nitpick - this repo is currently public, so perhaps better to not link issues from the internal backlog here)
Locking version due to: