-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor formatting issues #45
Conversation
🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-45.surge.sh 🎊 |
@@ -113,20 +113,20 @@ The table is a work in progress and will be updated as more functions are implem | |||
|BUILD_SCOPED_FILE_URL|❓|❓| | |||
|BUILD_STAGE_FILE_URL|❓|❓| | |||
|CASE|❓|❓| | |||
|CAST , ::|❓|❓| | |||
|CAST|❓|❓| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think , ::
is left to suggest ::
as the other alternative to CAST
:
https://docs.snowflake.com/en/sql-reference/functions/cast
But I may agree to put it as a code format to look better maybe?
|COALESCE|✅|✅| | ||
|COLLATE|❓|❓| | ||
|COLLATION|❓|❓| | ||
|COMPLETE (SNOWFLAKE.CORTEX)|❓|❓| | ||
|COMPLETE_TASK_GRAPHS|❓|❓| | ||
|COMPRESS|❓|❓| | ||
|CONCAT , |||✅|✅| | ||
|CONCAT|✅|✅| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here I would think , ||
is to suggest ||
as an alternative syntax for CONCAT
:
https://docs.snowflake.com/en/sql-reference/functions/concat
I can also see that there are some functions that we support by now that may need to be updated here such as:
cc: @HarshCasper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos for proactively fixing the docs in here @hovaesco ! 🚀 Unfortunately, the index.md
file is auto-generated, so these changes would be overwritten by the next CI run (we currently update the docs on a weekly schedule). So, we'd need to make those changes at the source directly - to dive into that in more detail..! 👍
Thanks @whummer it totally make sense, good insight 👍 I'm closing the PR then. Will fix in the code where applicable. |
Fix minor formatting issues.