Fix replacing host from environment variable AWS_ENDPOINT_URL #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe4dev
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Great work @jorgenfb 🥇
I tested the changes on macOS with the serverless.yml from #237 and can confirm your PR fixes the issue.
I could also reproduce the initial issue, i.e., without this fix, AWS_ENDPOINT_URL=http://localhost:4566 sls deploy --stage dev fails.
Thank you very much for this clean fix including a new regression test 🙏
| @@ -784,7 +784,7 @@ class LocalstackPlugin { | |||
| if (hostname && url.hostname === 'localhost') { | |||
| url.hostname = hostname; | |||
| } | |||
| return url.href; | |||
| return url.origin; | |||
| @@ -177,7 +177,28 @@ describe("LocalstackPlugin", () => { | |||
| expect(request.called).to.be.true; | |||
| let templateUrl = request.firstCall.args[2].TemplateURL; | |||
| // url should either start with 'http://localhost' or 'http://127.0.0.1 | |||
| expect(templateUrl).to.satisfy((url) => url.startsWith(`${config.host}`) || url.startsWith('http://127.0.0.1')); | |||
| expect(templateUrl).to.satisfy((url) => url === `${config.host}:4566/path/to/template` || url === 'http://127.0.0.1:4566/path/to/template'); | |||
There was a problem hiding this comment.
Yeah, I wanted to make sure that this test also made sure the urls are correct after my changes.
| expect(templateUrl).to.satisfy((url) => url === `${config.host}:4566/path/to/template` || url === 'http://127.0.0.1:4566/path/to/template'); | ||
| }); | ||
|
|
||
| it('should overwrite the S3 hostname with the value from environment variable', async () => { |
There was a problem hiding this comment.
kudos for adding this regression test case 👏 👏👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237