Skip to content

Commit

Permalink
fix version, delete unused file and update compose file
Browse files Browse the repository at this point in the history
  • Loading branch information
pinzon committed Jan 24, 2024
1 parent ab836ac commit b19122f
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 19 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ custom:
```
## Change Log
* v1.2.1: Add docker_compose config and fix autostart when plugin is not active
* v1.2.0: Add docker-compose config and fix autostart when plugin is not active
* v1.1.3: Fix replacing host from environment variable `AWS_ENDPOINT_URL`
* v1.1.2: Unify construction of target endpoint URL, add support for configuring `AWS_ENDPOINT_URL`
* v1.1.1: Fix layer deployment if `mountCode` is enabled by always packaging and deploying
Expand Down
23 changes: 10 additions & 13 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
version: '2'
version: "3.8"

services:
localstack:
container_name: "${LOCALSTACK_DOCKER_NAME:-localstack-main}"
image: localstack/localstack
ports:
- "4567-4582:4567-4582"
- "8080:8080"
- "127.0.0.1:4566:4566" # LocalStack Gateway
- "127.0.0.1:4510-4559:4510-4559" # external services port range
environment:
# Only start a subset of services required for testing.
- SERVICES=s3,sns,sqs,apigateway,lambda,dynamodb,dynamodbstreams,cloudformation
# - DEBUG=${DEBUG- }
# - DATA_DIR=${DATA_DIR- }
# - LAMBDA_EXECUTOR=${LAMBDA_EXECUTOR- }
# - KINESIS_ERROR_PROBABILITY=${KINESIS_ERROR_PROBABILITY- }
# - DOCKER_HOST=unix:///var/run/docker.sock
# volumes:
# - "${TMP_DIR:-/tmp/localstack}:${TMP_DIR:-/tmp/localstack}"
# - "/var/run/docker.sock:/var/run/docker.sock"
# LocalStack configuration: https://docs.localstack.cloud/references/configuration/
- DEBUG=${DEBUG:-0}
volumes:
- "${LOCALSTACK_VOLUME_DIR:-./volume}:/var/lib/localstack"
- "/var/run/docker.sock:/var/run/docker.sock"
2 changes: 0 additions & 2 deletions example/service/test/serverless.yml

This file was deleted.

2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "serverless-localstack",
"version": "1.2.1",
"version": "1.2.0",
"description": "Connect Serverless to LocalStack!",
"main": "src/index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ class LocalstackPlugin {
* Start the LocalStack container in Docker, if it is not running yet.
*/
startLocalStack() {
if (!this.config.autostart || !this.isActive()) {
if (!(this.config.autostart && this.isActive())) {
return Promise.resolve();
}

Expand Down

0 comments on commit b19122f

Please sign in to comment.