-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add gov cloud to ssm #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @maxhoheiser. We can keep this here until we can find a way to automate it upstream.
Could you add a small sanity test to verify that these values can be retrieved for the GovCloud partitions within SSM?
If we want to get it in today in the support week, I am not able to add the test. Maybee I have time next week. |
4395cfb
to
3b5cee8
Compare
9e621f2
to
8155751
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this 💯
Unless this is required to go in v3.7, I'll bump Moto-Ext sometime next week
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
* feat: add gov-cloud region us east 1 * feat: add gov-cloud region us west 1 * feat: add test for gov cloud ssm parameters * Add integration test --------- Co-authored-by: Viren Nadkarni <[email protected]>
This PR adds the SSM AWS Linux resources available in two not publicly available gov cloud regions - us-gov-east-1 and us-gov-west-1.
The data was provided by a customer who preferred not to share the original AMI values; hence, these values are randomly generated and differ from the official AWS values.
This PR was originally proposed to moto origin, but due to automatic update concerns not accepted: getmoto#8006