Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add gov cloud to ssm #74

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

maxhoheiser
Copy link
Member

This PR adds the SSM AWS Linux resources available in two not publicly available gov cloud regions - us-gov-east-1 and us-gov-west-1.

The data was provided by a customer who preferred not to share the original AMI values; hence, these values are randomly generated and differ from the official AWS values.

This PR was originally proposed to moto origin, but due to automatic update concerns not accepted: getmoto#8006

@maxhoheiser maxhoheiser self-assigned this Aug 23, 2024
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @maxhoheiser. We can keep this here until we can find a way to automate it upstream.

Could you add a small sanity test to verify that these values can be retrieved for the GovCloud partitions within SSM?

@maxhoheiser
Copy link
Member Author

Thanks for adding this @maxhoheiser. We can keep this here until we can find a way to automate it upstream.

Could you add a small sanity test to verify that these values can be retrieved for the GovCloud partitions within SSM?

If we want to get it in today in the support week, I am not able to add the test. Maybee I have time next week.

@maxhoheiser maxhoheiser force-pushed the feature/add-gov-cloud-to-ssm branch from 4395cfb to 3b5cee8 Compare August 27, 2024 09:54
@viren-nadkarni viren-nadkarni force-pushed the feature/add-gov-cloud-to-ssm branch from 9e621f2 to 8155751 Compare August 27, 2024 10:07
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 💯

Unless this is required to go in v3.7, I'll bump Moto-Ext sometime next week

@maxhoheiser maxhoheiser merged commit 788f0b0 into localstack Aug 27, 2024
48 checks passed
@alexrashed alexrashed deleted the feature/add-gov-cloud-to-ssm branch August 27, 2024 12:05
viren-nadkarni added a commit that referenced this pull request Aug 27, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Aug 29, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Sep 2, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Sep 2, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Sep 23, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Sep 24, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Sep 27, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Sep 27, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Oct 9, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Oct 14, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Oct 18, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Oct 28, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Nov 12, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
viren-nadkarni added a commit that referenced this pull request Dec 9, 2024
* feat: add gov-cloud region us east 1

* feat: add gov-cloud region us west 1

* feat: add test for gov cloud ssm parameters

* Add integration test

---------

Co-authored-by: Viren Nadkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants