Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique listener ids #73

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Unique listener ids #73

merged 1 commit into from
Dec 12, 2023

Conversation

simonrw
Copy link

@simonrw simonrw commented Dec 8, 2023

Motivation

If multiple ELBv2 listeners are created for the same load balancer, and the port is the same then the listeners will have the same ARN and therefore ID. This is particularly important for LocalStack where by default we rewrite all ports to use the edge port 4566. On real AWS it is likely that there cannot be multiple listeners for the same port, so is likely not a problem for upstream moto.

Changes

This PR assigns a random id to the listener, which in turn assigns a unique arn.

@simonrw simonrw self-assigned this Dec 8, 2023
@simonrw simonrw marked this pull request as ready for review December 8, 2023 17:14
viren-nadkarni
viren-nadkarni approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@viren-nadkarni viren-nadkarni merged commit 8ae8d7f into localstack Dec 12, 2023
29 checks passed
@viren-nadkarni viren-nadkarni deleted the elb-distinct-arns branch December 12, 2023 10:57
viren-nadkarni pushed a commit that referenced this pull request Dec 12, 2023
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
ee18937
@viren-nadkarni viren-nadkarni mentioned this pull request Dec 12, 2023
Merged
viren-nadkarni pushed a commit that referenced this pull request Jan 8, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
b6bda0a
alexrashed pushed a commit that referenced this pull request Jan 24, 2024
@simonrw @alexrashed
ELBv2: Use random listener IDs (#73)
7cd286b
viren-nadkarni pushed a commit that referenced this pull request Jan 29, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
76f7f51
viren-nadkarni pushed a commit that referenced this pull request Jan 29, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
f7ab328
viren-nadkarni pushed a commit that referenced this pull request Feb 20, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
4754126
viren-nadkarni pushed a commit that referenced this pull request Mar 4, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
bc6f621
viren-nadkarni pushed a commit that referenced this pull request Mar 4, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
e73033f
viren-nadkarni pushed a commit that referenced this pull request Mar 4, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
c6da83b
viren-nadkarni pushed a commit that referenced this pull request Mar 5, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
c2bdee0
viren-nadkarni pushed a commit that referenced this pull request Mar 19, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
60fb7ed
viren-nadkarni pushed a commit that referenced this pull request Apr 2, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
e7cf92b
viren-nadkarni pushed a commit that referenced this pull request Apr 11, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
2a52ef3
viren-nadkarni pushed a commit that referenced this pull request May 3, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
7d97c37
viren-nadkarni pushed a commit that referenced this pull request May 10, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
1a763f3
viren-nadkarni pushed a commit that referenced this pull request May 17, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
ed4a2f8
viren-nadkarni pushed a commit that referenced this pull request May 22, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
65f21d2
viren-nadkarni pushed a commit that referenced this pull request May 27, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
b7047a5
viren-nadkarni pushed a commit that referenced this pull request Jun 7, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
2f25696
viren-nadkarni pushed a commit that referenced this pull request Jun 20, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
54fd317
viren-nadkarni pushed a commit that referenced this pull request Jul 3, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
bddc4ed
viren-nadkarni pushed a commit that referenced this pull request Jul 18, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
1f3a788
viren-nadkarni pushed a commit that referenced this pull request Aug 9, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
da803a8
viren-nadkarni pushed a commit that referenced this pull request Aug 9, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
175eebc
viren-nadkarni pushed a commit that referenced this pull request Aug 9, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
08019f0
viren-nadkarni pushed a commit that referenced this pull request Aug 20, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
cd81df2
viren-nadkarni pushed a commit that referenced this pull request Aug 27, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
e265837
viren-nadkarni pushed a commit that referenced this pull request Aug 29, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
494172a
viren-nadkarni pushed a commit that referenced this pull request Sep 2, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
179ef08
viren-nadkarni pushed a commit that referenced this pull request Sep 2, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
b5be2fa
viren-nadkarni pushed a commit that referenced this pull request Sep 23, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
fec6b87
viren-nadkarni pushed a commit that referenced this pull request Sep 24, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
056c951
viren-nadkarni pushed a commit that referenced this pull request Sep 27, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
fd87b97
viren-nadkarni pushed a commit that referenced this pull request Sep 27, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
51e7c4a
viren-nadkarni pushed a commit that referenced this pull request Oct 9, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
3c025e4
viren-nadkarni pushed a commit that referenced this pull request Oct 14, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
95a7fdd
viren-nadkarni pushed a commit that referenced this pull request Oct 18, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
78a47c0
viren-nadkarni pushed a commit that referenced this pull request Oct 28, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
bd07e26
viren-nadkarni pushed a commit that referenced this pull request Nov 12, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
8ca69c8
viren-nadkarni pushed a commit that referenced this pull request Dec 9, 2024
@simonrw @viren-nadkarni
ELBv2: Use random listener IDs (#73)
61f1f43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

Assignees

@simonrw simonrw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @viren-nadkarni