Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDS: Patch the list of valid DB engines #72

Merged
merged 1 commit into from
Nov 21, 2023
Merged

RDS: Patch the list of valid DB engines #72

merged 1 commit into from
Nov 21, 2023

Conversation

viren-nadkarni
Copy link
Member

getmoto#7002 introduced additional validations for RDS engine types.

This PR updates the list of valid engines as in LocalStack.

@viren-nadkarni viren-nadkarni self-assigned this Nov 21, 2023
@viren-nadkarni viren-nadkarni mentioned this pull request Nov 21, 2023
Merged
steffyP
steffyP approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, @viren-nadkarni! 🙏
LGTM!

@viren-nadkarni viren-nadkarni merged commit 0aa7fc1 into localstack Nov 21, 2023
29 checks passed
@viren-nadkarni viren-nadkarni deleted the rds-valid-engines branch November 21, 2023 09:37
viren-nadkarni added a commit that referenced this pull request Dec 12, 2023
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
82f3902
viren-nadkarni added a commit that referenced this pull request Jan 8, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
a12bd77
alexrashed pushed a commit that referenced this pull request Jan 24, 2024
@viren-nadkarni @alexrashed
RDS: Patch the list of valid DB engines (#72)
ab20b2c
viren-nadkarni added a commit that referenced this pull request Jan 29, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
4c82392
viren-nadkarni added a commit that referenced this pull request Jan 29, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
b1aef6a
viren-nadkarni added a commit that referenced this pull request Feb 20, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
45f1e0e
viren-nadkarni added a commit that referenced this pull request Mar 4, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
036a510
viren-nadkarni added a commit that referenced this pull request Mar 4, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
f995cdc
viren-nadkarni added a commit that referenced this pull request Mar 4, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
66b8a0f
viren-nadkarni added a commit that referenced this pull request Mar 5, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
5c60284
viren-nadkarni added a commit that referenced this pull request Mar 19, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
b3e8788
viren-nadkarni added a commit that referenced this pull request Apr 2, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
21389bc
viren-nadkarni added a commit that referenced this pull request Apr 11, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
93d671b
viren-nadkarni added a commit that referenced this pull request May 3, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
f15024c
viren-nadkarni added a commit that referenced this pull request May 10, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
99479df
viren-nadkarni added a commit that referenced this pull request May 17, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
5ff16f7
viren-nadkarni added a commit that referenced this pull request May 22, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
2bd31be
viren-nadkarni added a commit that referenced this pull request May 27, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
fae59f9
viren-nadkarni added a commit that referenced this pull request Jun 7, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
ef1cdaa
viren-nadkarni added a commit that referenced this pull request Jun 20, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
04661fa
viren-nadkarni added a commit that referenced this pull request Jul 3, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
022c04e
viren-nadkarni added a commit that referenced this pull request Jul 18, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
bd4ca19
viren-nadkarni added a commit that referenced this pull request Aug 9, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
176a3dd
viren-nadkarni added a commit that referenced this pull request Aug 9, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
a989825
viren-nadkarni added a commit that referenced this pull request Aug 9, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
b468bfd
viren-nadkarni added a commit that referenced this pull request Aug 20, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
7cb1511
viren-nadkarni added a commit that referenced this pull request Aug 27, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
9b6105d
viren-nadkarni added a commit that referenced this pull request Aug 29, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
13a241e
viren-nadkarni added a commit that referenced this pull request Sep 2, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
75094aa
viren-nadkarni added a commit that referenced this pull request Sep 2, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
5c5cd30
viren-nadkarni added a commit that referenced this pull request Sep 23, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
cacb3da
viren-nadkarni added a commit that referenced this pull request Sep 24, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
544e12c
viren-nadkarni added a commit that referenced this pull request Sep 27, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
87f41ef
viren-nadkarni added a commit that referenced this pull request Sep 27, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
f9b85d0
viren-nadkarni added a commit that referenced this pull request Oct 9, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
b8ca189
viren-nadkarni added a commit that referenced this pull request Oct 14, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
f843e5a
viren-nadkarni added a commit that referenced this pull request Oct 18, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
0b518c3
viren-nadkarni added a commit that referenced this pull request Oct 28, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
3efa10d
viren-nadkarni added a commit that referenced this pull request Nov 12, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
2b6db03
viren-nadkarni added a commit that referenced this pull request Dec 9, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
4d282fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffyP steffyP steffyP approved these changes

Assignees

@viren-nadkarni viren-nadkarni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viren-nadkarni @steffyP