Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin wrangler version to fix hanging miniflare invocations #86

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

whummer
Copy link
Member

@whummer whummer commented Nov 23, 2024

This PR contains a few fixes to make the Miniflare extension compatible with the latest version of wrangler, and with LocalStack 4.0:

  • pin wrangler version to fix hanging miniflare invocations (with the latest version, the invocation to the wrangler dev server in the LS container hangs indefinitely, and we're not receiving a response)
  • remove installation of miniflare npm package, as the dev mode is now natively integrated into wrangler directly
  • fix encoding headers for invocation responses

@whummer whummer requested a review from HarshCasper as a code owner November 23, 2024 16:33
@@ -102,7 +107,6 @@ def do_run(self):
cmd = [
wrangler_bin,
"dev",
"--experimental-local",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecated argument / no longer required ...

@@ -134,5 +138,4 @@ def _install(self, target: InstallTarget) -> None:
run(["apt", "install", "-y", "libc++-dev"])

# install npm package
run(["npm", "install", "--prefix", target_dir, "wrangler"])
run(["npm", "install", "--prefix", target_dir, "@miniflare/tre"])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer required to install miniflare separately - now fully integrated into the wrangler CLI

@whummer whummer merged commit 9ef83b6 into main Nov 23, 2024
2 checks passed
@whummer whummer deleted the miniflare-fix branch November 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant