Remove copy/replicate mode and focus on cloud proxy in replicator extension #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
force-pushed
the
rename-to-proxy
branch
from
674e6bf to
f5da821
Compare
simonrw
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Thanks for cleaning this up. A minor suggestion is that we should probably not remove the operating instructions until we have actually removed the functionality.
Perhaps we could add a link to the last commit including the old readme section (i.e. the parent commit to this PR) that includes these instructions, so at least it's not visible by default, but still reachable. Just in case users are still using the extension with older LS versions.
E.g.
Resource Replicator CLI (deprecated)
If you with to access the deprecated instructions, they can be found here.
What do you think? I will leave the final decision to you.
|
Great point, thanks @simonrw - updated the PR to include a pointer to the last commit with the old docs. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove copy/replicate mode and focus on the cloud proxy capability in the aws-replicator extension.
This is a first step towards untangling the functionality - mostly focusing on the README for now. More changes following in upcoming iterations, in particular renaming this extension to
cloud-proxy(oraws-cloud-proxy). Also, the deprecated/unused code of the "replicate" command still needs to be stripped out and removed from the repo..