Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate imports from localstack_ext to localstack.pro.core #72

Merged
merged 1 commit into from
Jul 17, 2024
Merged

migrate imports from localstack_ext to localstack.pro.core #72

merged 1 commit into from
Jul 17, 2024

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Jul 15, 2024 •
edited
Loading

Motivation

After migrating localstack/localstack to implicit namespace packaging with localstack/localstack#11190, we are now moving towards namespace packages for our Pro code, which comes with some necessary adjustments of any imports from Pro: localstack_ext becomes localstack.pro.core.

This PR prepares the adjustment of the imports and should be merged as soon as the first dev package with the new namespace packaging in the localstack_ext distribution is out.

Changes

  • Adjusts the imports of localstack_ext modules.
  • Also contains some formatting fixes done automatically by make format.

@alexrashed alexrashed self-assigned this Jul 15, 2024
@alexrashed alexrashed force-pushed the fix-localstack-pro-imports branch 2 times, most recently from 843f999 to 98eb80d Compare July 17, 2024 09:00
@alexrashed alexrashed marked this pull request as ready for review July 17, 2024 09:01
@alexrashed alexrashed force-pushed the fix-localstack-pro-imports branch from 98eb80d to 6bf1120 Compare July 17, 2024 09:07
dominikschubert
dominikschubert approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good idea with the compatibility across both localstack_ext and localstack.pro.core!

@alexrashed alexrashed merged commit ea21a52 into main Jul 17, 2024
1 check passed
@alexrashed alexrashed deleted the fix-localstack-pro-imports branch July 17, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@lukqw lukqw Awaiting requested review from lukqw lukqw is a code owner

@thrau thrau Awaiting requested review from thrau thrau is a code owner

@whummer whummer Awaiting requested review from whummer whummer is a code owner

Assignees

@alexrashed alexrashed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrashed @dominikschubert