AWS Replicator - regex match secretsmanager
secrets based on their ARNs
#70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specific proxy configs like:
Should be able to cast requests to upstream AWS for ARNs like
arn:aws:secretsmanager:.+:secret:airflow/variables/.*
, and everything else to LocalStack.Limitations
Currently, this is only applicable to direct gets on said resources. The merging of the results from LocalStack and upstream AWS still has to be implemented in a subsequent PR.
In addition to that, regex matching the
account_id
andregion_name
params won't work because it will not represent the real values coming from upstream AWS. @whummer let me know if I'm missing anything here.Future selves
Tests ought to be added as well in future PRs.