Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usages of deprecated HttpRequest #65

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

alexrashed
Copy link
Member

Motivation

With localstack/localstack#9757 we would like to remove localstack.aws.api.HttpRequest, which is just a type alias for localstack.http.Request which was introduced even before LocalStack 1.0 (with localstack/localstack#5478).

Changes

  • Migrates imports / usages from localstack.aws.api.HttpRequest to localstack.http.Request.

@alexrashed alexrashed force-pushed the remove-usages-of-httprequest branch from decc467 to 316c978 Compare June 7, 2024 08:49
@alexrashed alexrashed requested a review from thrau June 7, 2024 08:54
@alexrashed alexrashed marked this pull request as ready for review June 7, 2024 08:54
@alexrashed alexrashed requested a review from whummer as a code owner June 7, 2024 08:54
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@alexrashed alexrashed merged commit ea3478e into main Jun 7, 2024
1 check passed
@alexrashed alexrashed deleted the remove-usages-of-httprequest branch June 7, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants