add http2-server to aws-replicator #64
Conversation
There was a problem hiding this comment.
Thanks a lot for moving this code here as an intermediary step! This allows us to move forward with getting rid of the dependencies in localstack-core.
I only added a comment to add hypercorn to the dependencies of this extension to prepare its removal in localstack-core as well.
| from hypercorn import utils as hypercorn_utils | ||
| from hypercorn.asyncio import serve, tcp_server | ||
| from hypercorn.config import Config | ||
| from hypercorn.events import Closed | ||
| from hypercorn.protocol import http_stream |
There was a problem hiding this comment.
Would be great to add hypercorn to the list of dependencies of this extension.
While quart is explicitly set in the dependencies of this extension, hypercorn and its transitive dependency h11 are not. This is not yet a problem for removing quart from the list of dependencies in localstack-core, but since hypercorn is not the default gateway implementation anymore it is likely to be removed sometime soon as well.
This is a provisional measure so we can move forward with removing quart and the leftover http2 server code from localstack.
I tried for an afternoon to replace the http2 server completely with a new gateway/handler chain approach in #62 , but just couldn't get it working. I got impatient so I decided to just move the http2_server.py from localstack to here, so we can remove it upstream.