Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify aws credentials text field type to password #58

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

HarshCasper
Copy link
Member

This PR adds TextField as password to ensure secure entry for AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY and AWS_SESSION_TOKEN during demos or live sessions.

@HarshCasper HarshCasper requested a review from whummer as a code owner April 2, 2024 05:16
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for adding that @HarshCasper ! 👍

The UI needs a general overhaul soon - I have a few ideas on how we can improve the UX there.. To be discussed

Btw, we're also going to need to release a new version, can you please bump the version and add a short description to the change log?

@HarshCasper HarshCasper merged commit c1abeba into main Apr 3, 2024
1 check passed
@HarshCasper HarshCasper deleted the text-type-password branch April 3, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants