Add configurations for aws-replicator proxy container #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
force-pushed
the
proxy-configs
branch
from
2680db3 to
88b3225
Compare
whummer
commented
Feb 9, 2024
| @@ -346,7 +349,13 @@ def start_aws_auth_proxy_in_container( | |||
| ] | |||
| env_vars = env_vars or os.environ | |||
| env_vars = select_attributes(dict(env_vars), env_var_names) | |||
| env_vars["LOCALSTACK_HOST"] = "host.docker.internal" | |||
There was a problem hiding this comment.
Note that this doesn't work in some Linux environments - we now leverage the get_docker_host_from_container() utility further below, which internally also returns host.docker.internal if that host resolves / is accessible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configurations for aws-replicator proxy container. These were added as part of a debugging session with a user who was using Linux with docker-compose networking, which caused the proxy container to not communicate properly with the LS main container.
The following configuration options have been added, to allow custom settings in different environments, and to improve debuggability:
REPLICATOR_CLEANUP_PROXY_CONTAINERS: whether to clean up (remove) the proxy Docker containers once they shut down (default1). Can be set to0to help debug issues, e.g., if a proxy container starts up and exits immediately.REPLICATOR_LOCALSTACK_HOST: the target host to use when the proxy container connects to the LocalStack main container (automatically determined by default)REPLICATOR_PROXY_DOCKER_FLAGS: additional flags that should be passed when creating the proxy Docker containersNote that transitional versions
0.1.8and0.1.9have already been published to pypi during the debugging session with the user - not an ideal pattern, but this helped significantly speed up the process, and we were able to get it working in the end. Once this PR is merged, we can release new version0.1.10.So far these changes were tested manually - no automated test have been added so far. This is something we can look into as a follow-up iteration, potentially.