Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to CI key #50

Merged
merged 1 commit into from
Feb 6, 2024
Merged

switch to CI key #50

merged 1 commit into from
Feb 6, 2024

Conversation

alexrashed
Copy link
Member

In an effort to increase our dogfooding, we are using our CI keys wherever possible. This PR switches from using a personal auth token to a dedicated CI key.

I already created the according CI key and set it as the value of the secret LOCALSTACK_API_KEY.

In an effort to increase our dogfooding, we are using our CI keys wherever possible. This PR switches from using a personal auth token to a dedicated CI key.

I already created the according CI key and set it as the value of the secret `LOCALSTACK_API_KEY`.
@alexrashed alexrashed added the enhancement New feature or request label Jan 30, 2024
@alexrashed alexrashed requested a review from whummer January 30, 2024 12:32
@alexrashed alexrashed self-assigned this Jan 30, 2024
@alexrashed alexrashed requested a review from thrau January 30, 2024 13:11
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @alexrashed !

I just realized that the tests for the aws-replicator tests are failing - will take a look at that shortly! (in a follow-up PR)

@alexrashed alexrashed merged commit cd7506c into main Feb 6, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants