Remove deprecated ProxyListener for starting local aws-replicator proxy server #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
force-pushed
the
remove-proxy-listener
branch
from
ba52e05 to
4211e34
Compare
whummer
force-pushed
the
remove-proxy-listener
branch
from
5a2eeda to
942fd3e
Compare
whummer
force-pushed
the
remove-proxy-listener
branch
from
942fd3e to
2805420
Compare
whummer
force-pushed
the
remove-proxy-listener
branch
from
b511d83 to
fd57b8a
Compare
whummer
force-pushed
the
remove-proxy-listener
branch
from
da1f7bd to
b3d3485
Compare
whummer
force-pushed
the
remove-proxy-listener
branch
from
b3d3485 to
0549b13
Compare
lukqw
reviewed
Nov 13, 2023
| publish: clean-dist venv dist | ||
| $(VENV_RUN); pip install --upgrade twine; twine upload dist/* | ||
|
|
||
| clean-dist: clean | ||
| rm -rf dist/ | ||
|
|
||
| .PHONY: clean clean-dist dist install publish test | ||
| .PHONY: build clean clean-dist dist install publish test |
| @@ -47,6 +50,9 @@ | |||
| CONTAINER_CONFIG_FILE = "/tmp/ls.aws.proxy.yml" | |||
| CONTAINER_LOG_FILE = "/tmp/ls-aws-proxy.log" | |||
|
|
|||
| # default bind host if `bind_host` is not specified for the proxy | |||
| DEFAULT_BIND_HOST = "127.0.0.1" | |||
There was a problem hiding this comment.
maybe this extension may benefit from also using localstack_host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated
ProxyListenerfor starting local aws-replicator proxy server. See localstack/localstack#9581 Resolves aTODOthat we've had in the code for quite a long time already. Thanks @lukqw for spotting this! 🚀