Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed exclude module and added \n to cli command #28

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

cloutierMat
Copy link
Contributor

Motivation

In the process of running test for the release, we discovered 2 issues that this pr aims to address.

  • An error raised by pyinstaller Target module "importlib_resources" already imported as "ExcludedModule('importlib_resources',)".
  • An error raised in the Pro Non-Docker Smoke Test
❌ Error: EOF when reading a line
LocalStack extension.):   [3/9] project_slug (my-localstack-extension):   [4/9] module_name (my_localstack_extension):   [5/9] class_name (MyLocalstackExtension):   [6/9] full_name (Jane Doe):   [7/9] email ([email protected]):   [8/9] github_username (janedoe):   [9/9] version (0.1.0): 

Changes

  • Removed --exclude-module importlib_resources \ to prevent import conflict issue as importlib_resources is vendored with setuptools
  • Added an extra line to the create script as a new option now exists when creating an extension with the localstack extensions dev new command

@cloutierMat cloutierMat self-assigned this Aug 28, 2024
@cloutierMat cloutierMat requested a review from alexrashed August 28, 2024 17:14
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this!
The changes are looking good, but the changes to the extensions tests mean that a breaking change slipped in there. We should double-check if that is on purpose...
/cc @thrau @Pive01?

@cloutierMat cloutierMat merged commit e373727 into main Aug 28, 2024
6 checks passed
@cloutierMat cloutierMat deleted the fix/pro-test-and-install branch August 28, 2024 17:33
@thrau
Copy link
Member

thrau commented Aug 28, 2024

nothing intentional going on here, but this is a developer command, so no need to worry too much about a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants