Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix auth token handling for binary builds #17

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix auth token handling for binary builds #17

merged 1 commit into from
Nov 16, 2023

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Nov 16, 2023 •
edited
Loading

Motivation

This PR addresses issues with the LOCALSTACK_AUTH_TOKEN Pro activation.

Changes

  • Deactivates the brittle Docker tests on MacOS runners, unfortunately they fail way too often.
  • Ensures that all data files are included, fixing the auth token verification.
  • Adds a smoke test to check that auth token validation also works fine.

@alexrashed alexrashed self-assigned this Nov 16, 2023
@alexrashed alexrashed requested a review from dfangl November 16, 2023 17:17
@dfangl dfangl marked this pull request as ready for review November 16, 2023 17:18
dfangl
dfangl approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix in that short timeframe 🎉

@alexrashed alexrashed merged commit 3b9a241 into main Nov 16, 2023
6 checks passed
@alexrashed alexrashed deleted the fix-auth-token-handling branch November 16, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

Assignees

@alexrashed alexrashed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrashed @dfangl