Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cookiecutter package, add extensions dev new smoke test #13

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

alexrashed
Copy link
Member

Motivation

localstack extensions dev new depends on cookiecutter/cookiecutter in order to create a project stub based on the cookie cutter template in localstack/localstack-extensions.
However, the PyInstaller binary build of our LocalStack CLI does not add the cookiecutter package to the dependencies, which is why it's not added to the final package. This results in the following error when using localstack extensions dev new with the binary build of the LocalStack CLI:

$ localstack extensions dev new
Error: this command requires the cookiecutter CLI, please run:
pip install cookiecutter

This PR fixes this issue by adding the package to the binary build.

Changes

  • Adds cookiecutter to the requirements
  • Adds a hook to allow building the cookiecutter package with pyinstaller.

Testing

  • Adds a new step for Pro smoke tests which checks that localstack extensions dev new with all-defaults results in a newly generated python project containing the LocalStack extensions boilerplate code.

@alexrashed alexrashed requested a review from thrau October 13, 2023 09:13
@alexrashed alexrashed self-assigned this Oct 13, 2023
@alexrashed alexrashed force-pushed the fix-extensions-dev-new branch 2 times, most recently from 9738aef to cf674bd Compare October 13, 2023 09:23
@alexrashed alexrashed force-pushed the fix-extensions-dev-new branch from cf674bd to 4238876 Compare October 13, 2023 09:39
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

@alexrashed alexrashed merged commit bc5b005 into main Oct 16, 2023
6 checks passed
@alexrashed alexrashed deleted the fix-extensions-dev-new branch October 16, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants