Fix filesystem permission parity #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
joe4dev
commented
Oct 4, 2023
| log.Warnln("Could not change file mode recursively of directory /opt:", err) | ||
| } | ||
| // fix permissions of the tmp directory for better AWS parity | ||
| if err := ChmodRecursively("/tmp", 0700); err != nil { |
There was a problem hiding this comment.
Should we do that for the directory only assuming that in ephemeral environments /tmp should be empty 🤔 ?
I guess that's mostly relevant for custom worker scenarios.
There was a problem hiding this comment.
I think in custom worker scenarios we might want to clear the /tmp directory anyway?
There was a problem hiding this comment.
I fully agree 👍 . Assuming an empty /tmp directory seems fair.
Hence, it doesn't matter too much.
There was a problem hiding this comment.
FYI custom worker currently cleans /tmp, /var/task and /opt
dfangl
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses localstack/localstack#8897
Changes
/opt(layers directory) to0755/tmpto0700ChmodRecursivelyUnrelated changes:
Testing
Run the test
tests.aws.services.lambda_.test_lambda.TestLambdaLayerBehavior.test_layer_permissionsin https://github.com/localstack/localstack-ext/pull/2165 against this new Go binary.