Set LOCALSTACK_HOST from service name #99
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LocalStack 3.0.0 standardises
LOCALSTACK_HOST
for services that return URLs. This configuration variable is substituted for domain names if customised. This means for example, that when creating an SQS queue, rather than receiving a queue URL of something like:you receive (with
LOCALSTACK_HOST=foo.bar
):This is important in k8s because the service name is a general DNS entry that resolves to the LocalStack pod. When users of the returned URL try to make calls to that URL, it will now succeed.
Changes
LOCALSTACK_HOST
environment variable to match the k8s service name