Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envFromSecret to support loading environment variables from a K8S Secret #97

Closed
wants to merge 2 commits into from

Conversation

sobotklp
Copy link

@sobotklp sobotklp commented Oct 6, 2023

This enables chart users to pull the LOCALSTACK_API_KEY (or some other variable) from a Kubernetes secret, which may be defined in a parent chart or by some other mechanism like IaC.

Refers to feature request #96

@alexrashed
Copy link
Member

Hi @sobotklp!
Thanks a lot for your contribution! I am really sorry we didn't answer on your issue earlier. Actually, the extraEnvVars ist just a list of objects which are added to the env vars of the deployment. So you can just reference a secret in the extraEnvVars.
Take a look at the docs added with 0e34a27 or at my comment in #96.
I am sorry for the inconvenience, but again: Thanks for the contribution! Please feel free to create other PRs if you stumble upon any issues.

@alexrashed alexrashed closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants