Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some sensible defaults and documentation #130

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Dec 18, 2024

Motivation

When running LocalStack on EKS on Fargate, the LocalStack pod often gets terminated. This is for two reasons:

  • the health probes are too restrictive, and
  • the default pod requests cause pods to be terminated too quickly

Changes

A consideration was made for both local and EKS/Fargate scenarios, so defaults were not updated to handle one scenario at the cost of the other.

  • Increase default probe delay and failure thresholds
    • these do make local development a little slower, but in my experience, LocalStack does not take much less than 10 seconds to become ready anyway
  • Add section to the docs on helm customzation
    • the defaults were not updated because this may cause resource exhaustion for local development which would not be a good user experience

@simonrw simonrw self-assigned this Dec 18, 2024
README.md Show resolved Hide resolved
@simonrw simonrw marked this pull request as ready for review December 18, 2024 23:02
@simonrw simonrw requested a review from alexrashed as a code owner December 18, 2024 23:02
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot for jumping on this! The new defaults are less strict than the ones before, so this is a backwards compatible change.
Also thanks a lot for proactively updating the README with additional information on how to set the resource limits! 🚀 📓

@alexrashed alexrashed merged commit 5de2597 into main Dec 20, 2024
2 checks passed
@alexrashed alexrashed deleted the update-defaults branch December 20, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants