add support to ingressClassName field #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for ingressClassName field
addind ingressClassName field
alexrashed
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Thanks for your contribution! But it looks like a duplicate for #118, where I just did the review and asked for some small changes. I would like to wait to see if @mproffitt addresses the comments first.
|
duplicate for #118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for ingressClassName field
Motivation
The annotation "kubernetes.io/ingress.class" is deprecated and the ingressClassName field on Ingresses is a replacement for that.
Changes
Enable support for ingressClassName field which is a replacement of the deprecated annotation "kubernetes.io/ingress.class"