Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the ingress class via spec.ingressClassName #118

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Allow setting the ingress class via spec.ingressClassName #118

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5edd028
Allow setting the ingress class via `spec.ingressClassName`
mproffitt Apr 24, 2024
7e7aeef
Code cleanup
mproffitt Apr 24, 2024
4cddb4e
Update wording on comment
mproffitt Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/localstack/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ metadata:
{{- tpl (toYaml .) $ | nindent 4 }}
{{- end }}
spec:
{{- if .Values.ingress.ingressClassName }}
ingressClassName: {{ .Values.ingress.ingressClassName | quote }}
{{- end }}

mproffitt marked this conversation as resolved.
Show resolved Hide resolved
{{- if .Values.ingress.tls }}
tls:
{{- range .Values.ingress.tls }}
Expand Down
11 changes: 10 additions & 1 deletion charts/localstack/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,18 @@ service:
ingress:
enabled: false
annotations: {}
# Adjust the ingress class when not using nginx as incress controller
# Adjust the ingress class when not using nginx as ingress controller
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"

# If you are using SSL passthrough for the certificates for nginx, uncomment the
# annotations below (note: nginx needs to be started with `--enable-ssl-passthrough` for these to work)
# nginx.ingress.kubernetes.io/backend-protocol: "HTTPS"
# nginx.ingress.kubernetes.io/ssl-passthrough: "true"
# nginx.ingress.kubernetes.io/ssl-redirect: "true"
mproffitt marked this conversation as resolved.
Show resolved Hide resolved

# To set the ingress class via spec.ingressClassName, uncomment the line below
# ingressClassName: nginx
hosts:
- host: chart-example.local
paths:
Expand Down