Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom priorityClassName #117

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

yahel2410
Copy link
Contributor

Motivation

Added support for custom priorityClassName. For cases when Localstack needs to be prioritized / de-prioritized over other pods

Changes

Added support for custom priorityClassName

Testing

Added a test value for common built-in priorityClassName

@yahel2410 yahel2410 force-pushed the feat/add-priorityclassname branch from 0aef721 to 5e7206c Compare March 25, 2024 11:41
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yahel2410! Thanks a lot for the contribution! I tested it locally and it works like a charm! I'll go ahead and directly merge the PR and create a release. 🚀 💯

@alexrashed alexrashed merged commit 4a5a48d into localstack:main Mar 26, 2024
2 checks passed
@yahel2410
Copy link
Contributor Author

yahel2410 commented Mar 26, 2024

@alexrashed awesome 😃
Thank you for the quick approval!

@yahel2410 yahel2410 deleted the feat/add-priorityclassname branch March 27, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants