add startupScript checksum to deployment #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Thanks for the contribution!
It is a best practice to use the hash of the file as annotation to trigger re-deployments on changes and I agree that one would like to have the changes in the init script being represented in the deployment. I also tested the changes locally, and they are looking good and working well! 🚀 💯
I'll move forward and merge + release this right away! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes in the StartupScripts are not applied to the deployment.
Changes
Add an annotation with the checksum of the StartupScriptContent to force the refresh of the deployment pod.