Added dnsConfig set to Default #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terFirst which causes a circular DNS lookup and crashes LocalStack
lakkeger
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default, if not specified, is ClusterFirst which causes a circular DNS lookup and crashes LocalStack
Motivation
This is a necessary setting to run LocalStack Pro with DNS configured. If this isn't set, a circular DNS lookup between the ls-dns K8S service and the LocalStack Pod crashes the LocalStack Pod instance.
With this value set to Default, the circular DNS lookup is averted because the Pod inherits the nodes
/etc/resolv.confwhich is set to 127.0.0.1 and doesn't connect to Coredns first.Changes
Allows the dnsConfig to be set in values.
Testing
Changes were tested on EKS Anywhere.