Add devcontainers-extra versions from the collections index for installsAfter #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lakkeger Please review at your earliest convenience. Many Thanks |
frankpengau
changed the title
alexrashed
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Hey @frankpengau! Thanks a lot for your contribution!
Could you give us a bit more context on the change you are suggesting?
Should these versions be added in addition or should they be replace the "contrib" features?
|
I was adding them in addition to the existing ones, just in case if anyone is still pulling in the old ones. But happy for you to replace them and release a new version and just advise others to stay on older version if they want to use previous devcontainers-contrib ones instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
devcontainers-extraversions forinstallsAfter."ghcr.io/devcontainers-extra/features/aws-cdk","ghcr.io/devcontainers-extra/features/pulumi",Ref: